Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issue #123 #355

Closed
wants to merge 1 commit into from
Closed

fix issue #123 #355

wants to merge 1 commit into from

Conversation

JumpLao
Copy link

@JumpLao JumpLao commented Dec 23, 2018 •
edited
Loading

Description

Related issues

#167 seem not fix the problem. the connector use getColumnsToAdd which not call buildColumnDefinitions so columnDbDefault not get call

Checklist

  • New tests added or existing tests modified to cover all changes
  • [/] Code conforms with the style
    guide

@slnode
Copy link

slnode commented Dec 23, 2018

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

@JumpLao
Copy link
Author

JumpLao commented Jan 23, 2019

@slnode test please

@raymondfeng
Copy link
Contributor

@JumpLao Thank you for the patch. Would you please add a test case?

@dhmlau
Copy link
Member

dhmlau commented Jan 24, 2019

@slnode test please

@devpascoe
Copy link

devpascoe commented Mar 1, 2019 •
edited
Loading

Looks like columnDbDefault isn't looking for defaultFn only default. Its not using the same default value checking as found in lookback-datasource-juggler lib/model.js _initProperties

@stale
Copy link

stale bot commented Jul 11, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 11, 2019
@stale
Copy link

stale bot commented Jul 25, 2019

This issue has been closed due to continued inactivity. Thank you for your understanding. If you believe this to be in error, please contact one of the code owners, listed in the CODEOWNERS file at the top-level of this repository.

@stale stale bot closed this Jul 25, 2019
@JuergenSimon JuergenSimon mentioned this pull request May 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-admike b-admike Awaiting requested review from b-admike

@dhmlau dhmlau Awaiting requested review from dhmlau dhmlau is a code owner

@jannyHou jannyHou Awaiting requested review from jannyHou

@virkt25 virkt25 Awaiting requested review from virkt25

@zbarbuto zbarbuto Awaiting requested review from zbarbuto

Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JumpLao @slnode @raymondfeng @dhmlau @devpascoe